fix(solana): injected connectors not detected #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@glitch-txs I'd like to get your thoughts on this. I'm still not quite clear if it's an issue on the Wallet Standard. I'll double check their source code and might open an issue on their repo to ask to WS team. |
enesozturk
changed the title
tomiir
reviewed
Aug 7, 2024
| @@ -25,6 +25,8 @@ export function watchStandard(callback: (arg: StandardWalletAdapter[]) => void) | |||
| }) | |||
| ] | |||
|
|
|||
| callback(standardAdapters) | |||
There was a problem hiding this comment.
While setting the event listeners, this allow us to trigger the callback with initial data of available wallets.
is this a default?
Not sure what you mean, but the Wallet Standard don't have this or idk why they don't trigger at once if MM is disabled. Asked here
tomiir
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wallet Standard's
onlistener is not getting triggered when MM is disabled but other extensions like Trust or Phantom is enabled. This causing an issue that the none of the injected wallets are getting visible in connector list if MM is not installed or disabled.This PR introduces a slight changes to the
watchStandardmethod to make sure it's passing the available options to it'scallbackparameter.Also adding a tests that checks the MM option in the injected connectors list.
While this resolving the issue, like to double checking the issue with the Wallet Standard team here: wallet-standard/wallet-standard#109
Type of change
Associated Issues
For Linear issues: Closes APKT-845
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist